Module talk:grc-accent
Add topicStripping function
[edit]@ObsequiousNewt I feel like I haven't been burdening you with enough menial tasks recently, so here is another: I recently discovered that the DGE's url search function actually uses lemmata without diacritics and will throw a hissy fit if it encounters an accent (see ἀπόθεος#References). Could you add a function that strips all the accents (including breathing marks) which I could use in Template:R:DGE? :D —JohnC5 21:45, 13 May 2015 (UTC)
- Yeah, eventually. I'll be gone for about the next two days, but I'll try and get that done before I leave. ObsequiousNewt (εἴρηκα|πεποίηκα) 13:34, 14 May 2015 (UTC)
- ἔκδυε to your heart's content. ObsequiousNewt (εἴρηκα|πεποίηκα) 14:22, 14 May 2015 (UTC)
Whoah there
[edit]@JohnC5 Why'd you need to add those new stripping tables? Was my implementation not working? (And the upsilon lacking smooth breathing is literally because Unicode doesn't encode it. At some point I may have to submit a proposal to add it.) ObsequiousNewt (εἴρηκα|πεποίηκα) 04:19, 16 May 2015 (UTC)
- @ObsequiousNewt: I'm sorry for meddling around in your module. I needed it to strip breathing marks too. Also, your implementation was changing ᾶ → ᾱ which was not intended, but I didn't want to change the tables you had already. —JohnC5 04:32, 16 May 2015 (UTC)
- @JohnC5 What you're describing sounds more like the function used for generating sort text... makeSortKey as I recall. ObsequiousNewt (εἴρηκα|πεποίηκα) 16:12, 16 May 2015 (UTC)
- @ObsequiousNewt: ...Yes. :V Well, feel free to remove that thing I wrote. I'm gonna go now... —JohnC5 20:33, 16 May 2015 (UTC)
- Actually, hold that last. The makeSortKey function does a couple extra things that I don't want like making the string uppercase and changing lunate sigma into normal sigma. I will however copy the method from makeSortKey into the accents section. —JohnC5 20:49, 16 May 2015 (UTC)
- @ObsequiousNewt: Did you miss my request to keep the newly edited form of the function? I need a function different than the sortKey function. —JohnC5 19:23, 18 May 2015 (UTC)
- What, you don't need to request. I mean, I see why it's necessary. Keep it. I don't own this module; I just make sure it works. ObsequiousNewt (εἴρηκα|πεποίηκα) 20:21, 18 May 2015 (UTC)
- Thanks, and I'm sorry to pester you so much. It seemed to be working perfectly in the last iteration... —JohnC5 20:45, 18 May 2015 (UTC)
- Oh, I see now. No, that revert is entirely not something I meant to do, and I'm not sure how it happened. Just fixing the three lengths back to what they were. ObsequiousNewt (εἴρηκα|πεποίηκα) 03:11, 19 May 2015 (UTC)
- Aha, it all makes sense now. Also, if you want, I realize that I could just move this functionality all into Module:R:DGE. There is no need for it to be here unless you'd like it here. —JohnC5 03:37, 19 May 2015 (UTC)
- If you want. I don't guess it matters much. ObsequiousNewt (εἴρηκα|πεποίηκα) 13:35, 19 May 2015 (UTC)
- Aha, it all makes sense now. Also, if you want, I realize that I could just move this functionality all into Module:R:DGE. There is no need for it to be here unless you'd like it here. —JohnC5 03:37, 19 May 2015 (UTC)
- Oh, I see now. No, that revert is entirely not something I meant to do, and I'm not sure how it happened. Just fixing the three lengths back to what they were. ObsequiousNewt (εἴρηκα|πεποίηκα) 03:11, 19 May 2015 (UTC)
- Thanks, and I'm sorry to pester you so much. It seemed to be working perfectly in the last iteration... —JohnC5 20:45, 18 May 2015 (UTC)
- What, you don't need to request. I mean, I see why it's necessary. Keep it. I don't own this module; I just make sure it works. ObsequiousNewt (εἴρηκα|πεποίηκα) 20:21, 18 May 2015 (UTC)
- @JohnC5 What you're describing sounds more like the function used for generating sort text... makeSortKey as I recall. ObsequiousNewt (εἴρηκα|πεποίηκα) 16:12, 16 May 2015 (UTC)
forKey
[edit]@Erutuon: the line of code local name = require("Module:table").keyFor(accent)
seems to be taking too few arguments. Am I missing something? —JohnC5 23:17, 29 August 2017 (UTC)
- @JohnC5: Oops, you're right. Fixed, I think. — Eru·tuon 23:49, 29 August 2017 (UTC)
Accent harmonization function
[edit]@JohnC5, Barytonesis, Angr Let me know if there are any weird cases of length marks appearing or disappearing in {{grc-decl}}
or {{grc-adecl}}
. This would be due to the harmonize_accent
function. I've fixed the error at ἄξιος (áxios), but there might be other weird stuff. (In this revision, the function replaced ἄξιος (áxios) with ᾱ̓́ξιος (ā́xios) because of the long vowel in the feminine ending ᾱ (ā).) — Eru·tuon 01:29, 15 September 2017 (UTC)
- @Erutuon: thanks, if I notice something I'll poke you. --Barytonesis (talk) 10:49, 15 September 2017 (UTC)